Fix issues preventing the queries tab from working #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the code to extract a query name to show in the queries panel, expects the incoming query to always have the `document.loc.source` attribute available. If this attribute isn't available, an exception is thrown, and the queries panel is displayed as a blank page. These changes adjust the logic used to extract a query label to be more flexible. The query name is now derivd by attempting the following (in order): 1. Attempt to parse and extract a query name from an incoming query string. 2. Check to see if the incoming query has already been parsed; if so extract the query name from the parsed document (e.g. happens when using `graphql-tag`). 3. If the incoming query has already been parsed, but the query name can't be extracted from the result, see if the document includes the original query source. If so, try re-parsing it, and re-extracting the query name. 4. If all else fails, fallback on using the query ID as the query name. Fixes #137.
This was referenced Oct 30, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the code to extract a query name to show in the queries panel, expects the incoming query to always have the
document.loc.sourceattribute available. If this attribute isn't available, an exception is thrown, and the queries panel is displayed as a blank page. These changes adjust the logic used to extract a query label to be more flexible. The query name is now derived by attempting the following (in order):graphql-tag).Fixes #137.