-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
apply spotless code-style formatter and header-license builder also #5481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 193 files out of 300 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…e the implementation of permission verification (apolloconfig#5456) * optimize: Implement unified permission verification logic: complete the unified permission validator and abstract common authentication logic. * optimize: Implement unified permission verification logic: reduce select BD times * test: Added some unit tests and fixed several methods. * add changes and license * add license * fix potential NPE * fix some error UT * fix error UT * format code * Code Optimization * bugfix * Code Optimization * code fix * format code style * change name * format code style by google style * format code only myself * tab format * tab format * tab format * Update format * Update UserPermissionValidator format * fix NPE and remove unnecessary function * fix validator use * remove uneccery change * remove unnecessary change * code fix * rebase * bug fix * fix ut * fix ut * fix ut * fix compatibility issue. * remove duplicate * fix ut * compatibility issue * remove duplicate string * ut * ut name * ut fix * simply code * bugfix * bugfix * not static * format code
…luster, Env, and Organization service endpoints (apolloconfig#5476) Co-authored-by: Zhangjian He <hezhangjian97@gmail.com>
…polloconfig#5474) Co-authored-by: Zhangjian He <hezhangjian97@gmail.com>
|
@nobodyiam Should we format the comments and java-doc ?I think to add a space between '//' and comments would be nice: Is these change appropriate as well? My idea is to retain the original multi-line comments in the docs, but format the single-line "//" comments. by setting xml: <setting id="org.eclipse.jdt.core.formatter.comment.format_block_comments" value="false"/>
<setting id="org.eclipse.jdt.core.formatter.comment.format_line_comments" value="true"/>
<setting id="org.eclipse.jdt.core.formatter.comment.format_javadoc_comments" value="false"/>My incorrect rebase operation seems to have messed up this branch; I'll create a new branch to do the work. 🥶 |



What's the purpose of this PR
See #5480
Brief changelog
Suggest remain this PR for 2-4 weeks, I will review it when I was slacking off at work.
Next step is append checker to CI-workflow
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.