Skip to content

Conversation

@spaceluke
Copy link
Member

@spaceluke spaceluke commented Oct 19, 2025

What's the purpose of this PR

See #5480

Brief changelog

  1. apply spotless code-style formatter plugin at pom.xml
  2. add header-license to control also
  3. apply the code formatter

Suggest remain this PR for 2-4 weeks, I will review it when I was slacking off at work.

Next step is append checker to CI-workflow

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Oct 19, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 19, 2025

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

193 files out of 300 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@spaceluke spaceluke added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Oct 20, 2025
@spaceluke spaceluke self-assigned this Oct 20, 2025
tacklequestions and others added 6 commits November 1, 2025 22:47
…e the implementation of permission verification (apolloconfig#5456)

* optimize: Implement unified permission verification logic: complete the unified permission validator and abstract common authentication logic.

* optimize: Implement unified permission verification logic: reduce select BD times

* test: Added some unit tests and fixed several methods.

* add changes and license

* add  license

* fix potential NPE

* fix some error UT

* fix  error UT

* format code

* Code Optimization

* bugfix

* Code Optimization

* code fix

* format code style

* change name

* format code style by google style

* format code only myself

* tab format

* tab format

* tab format

* Update format

* Update UserPermissionValidator format

* fix NPE and remove unnecessary function

* fix validator use

* remove uneccery change

* remove unnecessary change

* code fix

* rebase

* bug fix

* fix ut

* fix ut

* fix ut

* fix compatibility issue.

* remove duplicate

* fix ut

* compatibility issue

* remove duplicate string

* ut

* ut name

* ut fix

* simply code

* bugfix

* bugfix

* not static

* format code
…luster, Env, and Organization service endpoints (apolloconfig#5476)

Co-authored-by: Zhangjian He <hezhangjian97@gmail.com>
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Nov 1, 2025
@spaceluke
Copy link
Member Author

spaceluke commented Nov 1, 2025

@nobodyiam
I think these formatting steps are generally in line with our expectations, except for some minor issues with code comments, but that's fine~ we can improve them by configuring XML.

Should we format the comments and java-doc ?

I think to add a space between '//' and comments would be nice:
image

Is these change appropriate as well?
image
image

My idea is to retain the original multi-line comments in the docs, but format the single-line "//" comments.

by setting xml:

<setting id="org.eclipse.jdt.core.formatter.comment.format_block_comments" value="false"/>
<setting id="org.eclipse.jdt.core.formatter.comment.format_line_comments" value="true"/>
<setting id="org.eclipse.jdt.core.formatter.comment.format_javadoc_comments" value="false"/>

My incorrect rebase operation seems to have messed up this branch; I'll create a new branch to do the work. 🥶

@spaceluke spaceluke closed this Nov 2, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants