Skip to content

Implement parsing time based on pattern for @ApolloJsonValue #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 23, 2024

Conversation

huxleyliau
Copy link
Contributor

What's the purpose of this PR

Implement parsing time based on pattern for @ApolloJsonValue from #49

Which issue(s) this PR fixes:

Fixes #49

Brief changelog

Make use of Gson's current way of turning a string into a date to make @ApolloJsonValue able to handle time strings according to a given pattern.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 21, 2024
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (51efea6) 68.58% compared to head (97377d0) 68.63%.

Files Patch % Lines
...pring/property/AutoUpdateConfigChangeListener.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #53      +/-   ##
============================================
+ Coverage     68.58%   68.63%   +0.04%     
- Complexity     1207     1211       +4     
============================================
  Files           171      171              
  Lines          5198     5209      +11     
  Branches        561      562       +1     
============================================
+ Hits           3565     3575      +10     
  Misses         1372     1372              
- Partials        261      262       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 23, 2024
@nobodyiam nobodyiam merged commit 07ed79b into apolloconfig:main Jan 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
@nobodyiam nobodyiam added this to the 2.3.0 milestone Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ApolloJsonValue注解增加部分自定义功能
2 participants