Skip to content

Commit

Permalink
[refactor] Rename test file to allow any getpeerinfo deprecations.
Browse files Browse the repository at this point in the history
Simple rename/restructure to allow for upcoming test additions.
  • Loading branch information
amitiuttarwar committed Sep 22, 2020
1 parent 395acfa commit df091b9
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,25 @@
# Copyright (c) 2020 The Bitcoin Core developers
# Distributed under the MIT software license, see the accompanying
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
"""Test deprecation of getpeerinfo RPC banscore field."""
"""Test deprecation of getpeerinfo RPC fields."""

from test_framework.test_framework import BitcoinTestFramework


class GetpeerinfoBanscoreDeprecationTest(BitcoinTestFramework):
class GetpeerinfoDeprecationTest(BitcoinTestFramework):
def set_test_params(self):
self.num_nodes = 2
self.extra_args = [[], ["-deprecatedrpc=banscore"]]

def run_test(self):
self.test_banscore_deprecation()

def test_banscore_deprecation(self):
self.log.info("Test getpeerinfo by default no longer returns a banscore field")
assert "banscore" not in self.nodes[0].getpeerinfo()[0].keys()

self.log.info("Test getpeerinfo returns banscore with -deprecatedrpc=banscore")
assert "banscore" in self.nodes[1].getpeerinfo()[0].keys()


if __name__ == "__main__":
GetpeerinfoBanscoreDeprecationTest().main()
GetpeerinfoDeprecationTest().main()
2 changes: 1 addition & 1 deletion test/functional/test_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@
'feature_config_args.py',
'feature_settings.py',
'rpc_getdescriptorinfo.py',
'rpc_getpeerinfo_banscore_deprecation.py',
'rpc_getpeerinfo_deprecation.py',
'rpc_help.py',
'feature_help.py',
'feature_shutdown.py',
Expand Down

0 comments on commit df091b9

Please sign in to comment.