Fix active elements output not showing #1192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
markkuriekkinen
approved these changes
Jun 7, 2023
Contributor
markkuriekkinen
left a comment
markkuriekkinen
left a comment
There was a problem hiding this comment.
Great, this works well!
Commit ad95bc9 changed poll.js so that the final target URL is configured via an HTML data attribute. However, the new data attribute was not added for active elements, thus active elements could not load feedback to the output element after the submission had been graded. Fixes apluslms#1188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What?
Fix active elements output not showing
How?
Add the missing data-ready-url attribute.
Fixes #1188
Testing
Did a quick check that the output updates now.
Did you test the changes in
Is it Done?