Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support null value in where and prop #12

Merged
merged 2 commits into from
Dec 10, 2022
Merged

Conversation

khoale88
Copy link
Contributor

No description provided.

@j6k4m8
Copy link
Member

j6k4m8 commented Dec 10, 2022

This is so awesome, thank you for the contribution @khoale88! Would you be willing to write a unit-test or two to verify that this is working before merging? If not, I can add a few tomorrow or Monday and then I will merge it in ASAP.

I'm super grateful for your work here!! Thanks for making Grand-Cypher even better :)

@khoale88
Copy link
Contributor Author

This is so awesome, thank you for the contribution @khoale88! Would you be willing to write a unit-test or two to verify that this is working before merging? If not, I can add a few tomorrow or Monday and then I will merge it in ASAP.

I'm super grateful for your work here!! Thanks for making Grand-Cypher even better :)

Thank you. Will do it tmr.

@khoale88
Copy link
Contributor Author

Hi @j6k4m8 , I have updated the PR with 2 tests, one for note attribute, one for where. Can you check?
Anw, thank you for the great repo.

@j6k4m8
Copy link
Member

j6k4m8 commented Dec 10, 2022

Looks good @khoale88 !!! Thanks again, really excited this repository has been useful to you! Everything looks ready to me, is this okay with you to merge?

@khoale88
Copy link
Contributor Author

I am okay

@j6k4m8 j6k4m8 merged commit 09d326f into aplbrain:master Dec 10, 2022
@khoale88 khoale88 deleted the null_value branch December 10, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants