Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request logging #71

Merged
merged 22 commits into from
Dec 2, 2024
Merged

Add request logging #71

merged 22 commits into from
Dec 2, 2024

Conversation

itssimon
Copy link
Member

No description provided.

@itssimon itssimon marked this pull request as draft November 14, 2024 11:54
@itssimon itssimon self-assigned this Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 92.62295% with 36 lines in your changes missing coverage. Please review.

Project coverage is 92.45%. Comparing base (d8aacbc) to head (8ac57db).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
apitally/client/request_logging.py 95.02% 11 Missing ⚠️
apitally/client/client_asyncio.py 87.23% 6 Missing ⚠️
apitally/client/client_threading.py 88.09% 5 Missing ⚠️
apitally/litestar.py 88.88% 5 Missing ⚠️
apitally/starlette.py 89.74% 4 Missing ⚠️
apitally/common.py 75.00% 2 Missing ⚠️
apitally/flask.py 95.23% 2 Missing ⚠️
apitally/django.py 97.14% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   93.17%   92.45%   -0.72%     
==========================================
  Files          17       18       +1     
  Lines        1025     1418     +393     
==========================================
+ Hits          955     1311     +356     
- Misses         70      107      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itssimon itssimon marked this pull request as ready for review December 2, 2024 10:52
@itssimon itssimon merged commit 3086202 into main Dec 2, 2024
94 of 96 checks passed
@itssimon itssimon deleted the request-logging branch December 2, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant