fix: avoid loading room-native-api if USE_NATIVE_MODULE is disabled#743
Merged
fix: avoid loading room-native-api if USE_NATIVE_MODULE is disabled#743
Conversation
networkhermit
approved these changes
Apr 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
room-native-apipackage is still loaded if theUSE_NATIVE_MODULEenv var is disabled, which can lead to glibc version mismatching in the all-in-one image, that is, all-in-one image has glibc 2.29, but room-native-api is compiled against glibc 2.28. This problem is fixed by avoidingrequireingroom-native-apiat runtime ifUSE_NATIVE_MODULEis disabled.