Skip to content

Update .travis.yml #3744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 24, 2019
Merged

Update .travis.yml #3744

merged 5 commits into from
Apr 24, 2019

Conversation

ilarimikkonen
Copy link
Member

try build on a new branch from develop; previous got into dead end and totally messed

Closes #

Changes

Describe your changes here as a bulleted list:

  • change one
  • change two

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @username1

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

try build on a new branch from develop; previous got into dead end and totally messed
@ghost ghost assigned ilarimikkonen Apr 18, 2019
@ghost ghost added the in progress label Apr 18, 2019
making yarn verbose to see what is happening
update chimp to latest THERE IS MISMATCH WITH package-lock.json!!!!!
remove verbose from yarn + run metero npm install, so that yarn does not try to install. npm install should create needed fiber binaries
Copy link
Member

@matleppa matleppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be OK

@matleppa matleppa merged commit daf3277 into develop Apr 24, 2019
@ghost ghost removed the in progress label Apr 24, 2019
@matleppa matleppa deleted the devops/meteor-1.8-problems branch April 24, 2019 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants