Skip to content

Show API key instead of email in the table "Most frequent users" #3430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2018
Merged

Show API key instead of email in the table "Most frequent users" #3430

merged 1 commit into from
Mar 22, 2018

Conversation

marla-singer
Copy link
Contributor

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @username1

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

@marla-singer
Show API key instead of email in the table "Most frequent users"
9caa31a 
- Closes #3426
- Change en tags file
- Change request to ES
@ghost ghost assigned marla-singer Mar 21, 2018
@ghost ghost added the in progress label Mar 21, 2018
@marla-singer marla-singer requested review from 55, Nazarah and matleppa March 21, 2018 12:29
matleppa
matleppa approved these changes Mar 22, 2018
View reviewed changes
Copy link
Member

@matleppa matleppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

@matleppa matleppa merged commit e8be21d into develop Mar 22, 2018
@ghost ghost removed the in progress label Mar 22, 2018
@ilarimikkonen ilarimikkonen deleted the feature/use-api-key branch October 16, 2018 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matleppa matleppa matleppa approved these changes

@55 55 Awaiting requested review from 55

@Nazarah Nazarah Awaiting requested review from Nazarah

Assignees

@marla-singer marla-singer

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marla-singer @matleppa