Bugfix/ask email confirmation when adding organisation manager

[deligence-dharmendra]

Closes #3346

Changes

• changes in language, schema, organization router file
• add new send email verification and verify email method in organization method

Developer checklist

This checklist is to be completed by the PR developer:

• Alternative solutions were compared/discussed before writing code
  • trade-offs with this solution are considered acceptable
• Code in this PR adheres to the project styleguide
• This pull request does not decrease project test coverage
• If the code changes existing database collection(s), migration has been written
• If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @username1

This list is to be completed by the pull request reviewer:

• Code works as described/expected
• Code seems to be error free
  • no browser console errors visible
  • no server console errors visible
  • passes CI build
• Code is written in a way that promotes maintainability
  • easy to understand
  • well organized
  • follows project coding standards and conventions
  • well documented

[Nazarah]

Fix the following:
"In case mail sending fails, the s-alert notifying the user about this remains in the page.
It doesn't automatically vanishes."

[Nazarah]

@deligence-dharmendra @matleppa I was trying to test the fix from my localhost.
I tried to setup the email configuration from the settings and tried to add another user as a manager.
On clicking Add Manager, it shows the message "Sending Verification Email failed" as S alert.
The user isn't added eventually as an organization manager.
My question is that do I need to set up valid email configuration information (i.e. same as that in nightly APInf) in order to verify the mail settings?

[deligence-dharmendra]

@Nazarah Yes, you need to set up valid email configuration information. Otherwise, email id does not add to the organization and its show error message as an s-alert on the same page.

[Nazarah]

@deligence-dharmendra @matleppa Just ran the feature in my localhost.
When user confirms the email by clicking on the link, he gets redirected to the home page of APInf.
Shouldn't it be the case that on clicking the verification link, user gets redirected to the Organization profile page?

[marla-singer]

What about:

organization.emailVerification = [{....}];

?

[marla-singer]

1. i18n tag for this word is missed
2. Nested element should have a new line

[marla-singer]

Make invert of this if-else & simplify

// Construct empty object
let verificationData = {};
const result = _.find(organization.emailVerification, { managerIds: user._id });
if (result) {
  varidicationData = result
} else {  
verificationData.verified = organization.createdBy === user._id;
}

If organization.emailVerification is undefined then result variable is undefined as well
Remake

[matleppa]

@deligence-dharmendra I agree with @Nazarah about User getting redirected to Organization page while verificating.

[matleppa]

Some findings.

[matleppa]

Combine checks.
Outer check
response.status === 'failed'
inner checks
response.message === 'email-failed'
response.message === 'mail-setting-invalid'

[matleppa]

exists --> exist

[marla-singer]

@deligence-dharmendra Great job 👍 Work as expected
I made rebase to squash your commit