Skip to content

Add Authorized users to API by using username #3371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 5, 2018

Conversation

marla-singer
Copy link
Contributor

Closes #3365

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @username1

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

@marla-singer marla-singer force-pushed the feature/add-authorized-user-by-username branch from f213de7 to e7bd8e9 Compare January 31, 2018 13:20
@marla-singer marla-singer requested a review from anarva February 1, 2018 15:02
Copy link
Member

@matleppa matleppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality as expected.
However, should we make a little fix in order to make user experience better?

kuva

Correction to title:
Add authorized users --> Add new authorized user

Between title and input field a guidance text:
"Give either username or email address"

@marla-singer
Copy link
Contributor Author

Correction to title:
Add authorized users --> Add new authorized user

Don't agree, "new" is redundant

Between title and input field a guidance text:
"Give either username or email address"

Will do it

@matleppa
Copy link
Member

matleppa commented Feb 5, 2018

OK.

Add authorized users
-->
Add authorized user

Because users are added one at a time.

@marla-singer
Copy link
Contributor Author

marla-singer commented Feb 5, 2018

@matleppa Actual, the original text is in single number (button). Or did you mean the title?

Copy link
Contributor

@anarva anarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are fine.

@matleppa
Copy link
Member

matleppa commented Feb 5, 2018

The title, yes. Now it seems to be fine.

@matleppa matleppa merged commit 22adafc into develop Feb 5, 2018
@matleppa matleppa deleted the feature/add-authorized-user-by-username branch February 5, 2018 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants