Skip to content

Add an Organization manager by username #3369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 5, 2018

Conversation

marla-singer
Copy link
Contributor

Closes #3344

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @username1

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

@marla-singer marla-singer added this to the Sprint 62 milestone Jan 31, 2018
@marla-singer marla-singer requested a review from matleppa January 31, 2018 09:48
@ghost ghost assigned marla-singer Jan 31, 2018
@marla-singer marla-singer changed the title Feature/add manager by username Add an Organization manager by username Jan 31, 2018
@marla-singer marla-singer force-pushed the feature/add-manager-by-username branch from 30c68c9 to 9c8742d Compare January 31, 2018 12:26
@marla-singer marla-singer requested a review from anarva February 1, 2018 15:03
Copy link
Member

@matleppa matleppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality as expected.
However, we should unify the UIs of "Authorized users for API" and "Organization managers", because in both places a similar functionality is performed.

Remake UI of "Organization manager" to be similar as the UI of "Authorized users for API".

  • first is list of managers
  • below list is input field for new manager
  • Add button is below input field with text "Add new manager" and similar icon (fa fa-user) as in Authorized users.

@marla-singer
Copy link
Contributor Author

we should unify the UIs of "Authorized users for API" and "Organization managers", because in both places a similar functionality is performed.

Yes, UI the same but the value of User ID is inserted in the different collections 🤷‍♀️
About the second point, will remake

@matleppa
Copy link
Member

matleppa commented Feb 5, 2018

OK, I see, that I could have written more specific what I meant.

However, we should unify the UIs of "Authorized users for API" and "Organization managers",
-->
However, we should unify the look and feel of UIs of "Authorized users for API" and "Organization managers",

So, yes, the only goal is that the UIs are similar in both places.

@marla-singer
Copy link
Contributor Author

@matleppa Made UI changes

@matleppa matleppa merged commit 5a8210d into develop Feb 5, 2018
@matleppa matleppa deleted the feature/add-manager-by-username branch February 5, 2018 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants