Allow mocks for paths without a controllerName #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penx
force-pushed
the
feature/always-mock-paths
branch
from
9883210 to
3d9f3d1
Compare
penx
added a commit
to penx/openapi-mock
that referenced
this pull request
Feb 12, 2018
point to github commitish for swagger-node-runner for date support awaiting progress on: json-schema-faker/json-schema-faker#360 (comment) apigee-127/sway#168 apigee-127/swagger-node-runner#121 apigee-127/swagger-node-runner#119
9 tasks
Contributor
Author
|
@theganyo I'm hoping to use swagger-node-runner in a mock tool which is dependent on this fix and #121. Any chance on some feedback on these ? Or should I publish a fork with my fixes? https://github.com/penx/openapi-mock Thanks! |
Collaborator
|
No, These seem good. I've merged them. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118
This means, for example, that if you set
defaultPipe: swagger_controllersandcontrollerNameisundefined, then it skips looking for a controller (aspath.resolve(controllersDirs[i], controllerName)would error) and continues to making a mock.