Skip to content

fix: correct target stats when sockets are reused #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 10, 2025

Conversation

jirimoravcik
Copy link
Member

@jirimoravcik jirimoravcik commented Mar 7, 2025

This PR attempts to fix incorrect stats due to the reuse of target sockets for HTTP(S) protocols.

Based on #572

Note: I was forced to upgrade actions/cache as v2 was deprecated and it wouldn't run with it.
I also had to edit eslint config to run with . instead of src and excluded tests, because with src the CI was failing (no idea why).

The files changed in src are the ones relevant for the main topic of this PR.

@jirimoravcik jirimoravcik added the adhoc Ad-hoc unplanned task added during the sprint. label Mar 7, 2025
@jirimoravcik jirimoravcik requested a review from Copilot March 7, 2025 13:38
@github-actions github-actions bot added this to the 110th sprint - Platform team milestone Mar 7, 2025
@github-actions github-actions bot added the t-core-services Issues with this label are in the ownership of the core services team. label Mar 7, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@jirimoravcik jirimoravcik merged commit a507021 into master Mar 10, 2025
5 checks passed
@jirimoravcik jirimoravcik deleted the fix/correct-target-stats-socket-reuse branch March 10, 2025 08:15
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-core-services Issues with this label are in the ownership of the core services team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants