fix: improve EventEmitter types for Node 25
#168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
t-tooling
There was a problem hiding this comment.
Pull request overview
This PR updates the type signatures for listeners and rawListeners methods in the WrappedAgent class to ensure compatibility with Node.js 25 EventEmitter types. The changes address failing Crawlee E2E tests by using TypeScript utility types instead of explicit type annotations.
Key Changes:
- Replaced explicit parameter type
string | symbolwithParameters<HttpAgent['listeners']>[0]to derive the correct type from HttpAgent - Replaced explicit return type
Function[]withReturnType<HttpAgent['listeners']>to maintain type compatibility - Removed eslint-disable comments for
@typescript-eslint/ban-typesthat are no longer needed
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should unblock failing Crawlee E2E tests, see here.