Skip to content

expose getAgents #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
barjin merged 1 commit into from
Feb 3, 2025
Merged

expose getAgents #151

barjin merged 1 commit into from
Feb 3, 2025

Conversation

@Kikobeats
Copy link
Contributor

@Kikobeats Kikobeats commented Jan 24, 2025 •
edited
Loading

Hello,

proxyHook is cechking the got context to determine if agent can be added or not.

This PR exposes getAgents main method to be possible to use it out of got hook 🙂

@Kikobeats
Copy link
Contributor Author

Kikobeats commented Jan 28, 2025

@barjin, tests are failing, but I actually don't think they are related to my change 🤔

@barjin
Copy link
Member

barjin commented Jan 29, 2025

Thank you for your submission!

Yes, the failing tests seem to be related to a bug in the jest testing library. I'll look into this and see what can be done (we're slowly moving to vitest anyway :)).

Thanks again and sorry for the inconvenience.

@barjin barjin mentioned this pull request Feb 3, 2025
Merged
@barjin
Copy link
Member

barjin commented Feb 3, 2025

I switched the testing framework in a recent PR to master (#152 ), but now I see that the error is happening because of a missing GitHub Actions secret (this is likely because you're submitting the PR from an external fork, as you're not in the apify organization).

The function you're exposing seems externally useful to me too, so I'm all for merging this PR. Thanks!

@barjin barjin merged commit c4a7a36 into apify:master Feb 3, 2025
2 of 8 checks passed
@barjin barjin mentioned this pull request Feb 3, 2025
Merged
barjin added a commit that referenced this pull request Feb 3, 2025
@barjin
chore(ci): test against Node 22, update GH Actions (#153)
c34baa2 
Uses Node 22 in CI for build and testing purposes as discussed under
#152 . Updates third-party GitHub Actions to their latest versions.

Bumps the package version to `4.1.0` to fix the prerelease publish for
#151 .
@Kikobeats
Copy link
Contributor Author

Kikobeats commented Feb 9, 2025

@barjin can you cut a new version? 🙏

@Kikobeats
Copy link
Contributor Author

Kikobeats commented Feb 10, 2025

@barjin Thanks!

Unfortunately I didn't take into account the way the library is bundling the library.

Opened a new PR for exposing the method properly #154 🙂

@barjin barjin mentioned this pull request Jul 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kikobeats @barjin