Skip to content

chore(ci): Update renovate schedules#3830

Open
Pijukatel wants to merge 2 commits into
masterfrom
renovate-update
Open

chore(ci): Update renovate schedules#3830
Pijukatel wants to merge 2 commits into
masterfrom
renovate-update

Conversation

@Pijukatel

Copy link
Copy Markdown
Contributor

Use cron instead of deprecated schedule syntax

@barjin barjin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Pijukatel !

Looks fine to me, but I believe @B4nan might have more opinions about this.

Comment thread renovate.json Outdated
},
{
"matchUpdateTypes": ["lockFileMaintenance"],
"minimumReleaseAgeBehaviour": "timestamp-optional"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that npm supports release timestamps - is there a reason for making the timestamp checks optional?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how this should be properly used, but for lock file updates, this seems to stay forever waiting
image

In Python the reliable package age enforcer is the package manager regardless of the renovate timestamp-optional option. Not sure if the package manager here can guarantee this as well.

Comment thread renovate.json Outdated
"automergeType": "branch"
"enabled": true,
"automerge": true,
"automergeType": "pr",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the default option (docs), so we can drop the explicit setting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants