Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -551,7 +551,7 @@ export class RequestQueueClient extends BaseClient implements storage.RequestQue
existingQueueById.pendingRequestCount += requestWasHandledBeforeUpdate ? 1 : -1;
}

if (requestIsHandledAfterUpdate) {
if (isRequestHandledStateChanging && requestIsHandledAfterUpdate) {
existingQueueById.handledRequestCount += 1;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,24 @@ describe('RequestQueue handledRequestCount should update', () => {
const updatedStatistics = await requestQueue.get();
expect(updatedStatistics?.handledRequestCount).toEqual(2);
});

test('updating an already handled request should not increment the handledRequestCount again', async () => {
const { requestId } = await requestQueue.addRequest({
url: 'http://example.com/4',
uniqueKey: '4',
handledAt: new Date().toISOString(),
});

const { handledRequestCount } = (await requestQueue.get())!;

await requestQueue.updateRequest({
url: 'http://example.com/4',
uniqueKey: '4',
id: requestId,
handledAt: new Date().toISOString(),
});

const updatedStatistics = await requestQueue.get();
expect(updatedStatistics?.handledRequestCount).toEqual(handledRequestCount);
});
});
Loading