fix: unref BrowserController.close() fallback timer to avoid keeping Node alive longer than needed#3671
Open
simshaun wants to merge 1 commit into
Open
fix: unref BrowserController.close() fallback timer to avoid keeping Node alive longer than needed#3671simshaun wants to merge 1 commit into
simshaun wants to merge 1 commit into
Conversation
simshaun
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an event-loop retention issue in browser-pool where BrowserController.close() schedules a 5 second fallback kill timer that can keep Node alive after crawl work has already finished.
The timer is created and left referenced. This change keeps the fallback behavior intact but calls unref() on that timer so it does not block process exit.
Why this is needed
In current behavior, a minimal crawl can complete and all user work can be done, but process exit is delayed due to the fallback timer.
Minimal reproduction
Run any short crawler that exits immediately after crawler.run() and cleanup. Observe that process exit occurs ~5 seconds later than expected.