refactor(discoverValidSitemaps): check /sitemap_index.xml for sitemaps#3370
Merged
refactor(discoverValidSitemaps): check /sitemap_index.xml for sitemaps#3370
/sitemap_index.xml for sitemaps#3370Conversation
Member
|
changing the commit type to refactor, this feature is not released yet, it doesnt make sense to mention it in the changelog twice. |
B4nan
changed the title
/sitemap_index.xml for sitemaps/sitemap_index.xml for sitemaps
|
No reviews for this PR? ) |
Member
|
yeah, please next time don't just yolo things here, for actors its fine'ish, for a library like crawlee, its not. wait at least for one review. |
barjin
pushed a commit
that referenced
this pull request
Feb 6, 2026
…aps (#3370) Based on @nicklamonov 's remarks
barjin
added a commit
that referenced
this pull request
Feb 6, 2026
Rebases #3339 and #3370 on top of `v4` and adds `HttpClient` support for discoverValidSitemaps. Related to the discussion under apify/actor-scraper#214 --------- Co-authored-by: Sviatozar Petrenko <svpetrenko123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on @nicklamonov 's remarks