fix: log warning on sharing useState(), add id option to BasicCrawler

[barjin]

Adds unique crawler id to the BasicCrawler class. Prints a warning on multiple crawlers sharing the state on useState().

There might be more resources shared between different BasicCrawler (-subclass) instances - this needs further investigation.

Closes #3024

[barjin]

Looking at the current changes, this is actually not breaking and we could merge it to v3 now.

Thoughts @janbuchar @B4nan ? The id field name is up for discussion.

[janbuchar]

Looking at the current changes, this is actually not breaking and we could merge it to v3 now.

Thoughts @janbuchar @B4nan ? The id field name is up for discussion.

I slightly prefer going for v3. id sounds a bit too generic to me. Maybe we could just pass in the whole state key.

[B4nan]

I guess we should handle the crawler statistics this way too, and I would rather keep that for v4. And saying that, I would actually prefer some generic name not bound to the useState case.

[barjin]

The last commits are passing the crawler id to the Statistics constructor - based on my (not too extensive) research, that's all the resources that could have been shared / swapped by mistake before.

Regarding the identifier naming, I really don't have many ideas. How about (crawler|instance)Id?

[janbuchar]

SessionPool also comes to mind. Not sure if it's a problem to share it?

[barjin]

I believe there are valid reasons to share the Session instances (e.g. getting cookies using PlaywrightCrawler and then processing the data using HttpCrawler using these cookies). Currently the SessionPool instances all use the same KVS key to store their state.

But this is a good point nonetheless - we should consider the implications of this in the UserPool initiative.