fix: sitemap content-type check breaks on content-type parameters#2442
Merged
fix: sitemap content-type check breaks on content-type parameters#2442
content-type check breaks on content-type parameters#2442Conversation
barjin
added
bug
github-actions
bot
added
the
t-tooling
Contributor
|
Can we adopt https://www.npmjs.com/package/whatwg-mimetype and be done with this? It gives you a isXml method, which is all we ever wanted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the RFC1341, the Content-type header can contain additional string parameters.
This is sometimes used to communicate the encoding of the content (or other stuff(?)), like in
text/plain; charset=utf-8.The current sitemap implementation didn't expect this and skipped perfectly good sitemaps.