fix: return true when robots.isAllowed returns undefined#2439
Merged
janbuchar merged 2 commits intoapify:masterfrom May 3, 2024
Merged
fix: return true when robots.isAllowed returns undefined#2439janbuchar merged 2 commits intoapify:masterfrom
janbuchar merged 2 commits intoapify:masterfrom
Conversation
`undefined` means that there is no explicit rule for the requested route. No rules means no disallow, therefore it's allowed.
janbuchar
reviewed
May 2, 2024
Co-authored-by: Jan Buchar <Teyras@gmail.com>
janbuchar
approved these changes
May 3, 2024
Contributor
janbuchar
left a comment
janbuchar
left a comment
There was a problem hiding this comment.
Perfect, thank you very much for the code!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
undefinedmeans that there is no explicit rule for the requested route. No rules means no disallow, therefore it's allowed.Fixes #2437