Skip to content

fix: deprecation messages in CheerioCrawler and ProxyConfiguration#1129

Merged
mnmkng merged 4 commits intomasterfrom
fix/deprecation-messages
Aug 27, 2021
Merged

fix: deprecation messages in CheerioCrawler and ProxyConfiguration#1129
mnmkng merged 4 commits intomasterfrom
fix/deprecation-messages

Conversation

@mnmkng
Copy link
Member

@mnmkng mnmkng commented Aug 26, 2021

No description provided.

@mnmkng mnmkng requested review from B4nan and szmarczak August 26, 2021 15:40
Comment on lines +730 to +732
// TODO this is incorrect, the check for man in the middle needs to be done
// on individual proxy level, not on the `proxyConfiguration` level,
// because users can use normal + MITM proxies in a single configuration.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can do something about this atm. Can we?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's probably right. The thing is, if a user selects multiple groups including the MITM one, the group handling will be done on the Apify Proxy side, but we don't know which proxy group the backend will pick so we need to disable TLS for all of them.

Maybe we should just prevent the use of the MITM proxy together with other proxies.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should just prevent the use of the MITM proxy together with other proxies.

That's actually a good idea. Alternatively if #1119 was supported it would work as well. Although I think you're right, it might be moot since we can just pass a different proxyConfiguration...

@mnmkng mnmkng merged commit 7b7a971 into master Aug 27, 2021
@mnmkng mnmkng deleted the fix/deprecation-messages branch August 27, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants