feat: automatic logging setup#229
Merged
Merged
Conversation
janbuchar
commented
Jun 25, 2024
janbuchar
commented
Collaborator
- closes Automate default logging configuration for crawlers #214
janbuchar
added
the
t-tooling
github-actions
Bot
added
the
tested
janbuchar
commented
Jun 25, 2024
| send_request=self._prepare_send_request_function(session, proxy_info), | ||
| add_requests=result.add_requests, | ||
| push_data=self._push_data, | ||
| log=self._logger, |
Collaborator
Author
There was a problem hiding this comment.
@vdusek not sure about this - it may be nice to make a new logger with a name like crawlee.request_handler, but that doesn't match any module, so we'd break a convention.
Collaborator
There was a problem hiding this comment.
it will log request queue / request list otherwise - am I correct? if so, I'd not override it
Collaborator
Author
There was a problem hiding this comment.
more like crawlee.basic_crawler.basic_crawler, depending on your crawler
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.