Skip to content

Conversation

@Mantisus
Copy link
Collaborator

@Mantisus Mantisus commented Oct 23, 2025

@Mantisus Mantisus changed the title chore: improve HttpClient isolate in tests chore: improve HttpClient isolate in tests Oct 23, 2025
@Mantisus Mantisus changed the title chore: improve HttpClient isolate in tests chore: improve HttpClient isolating in tests Oct 23, 2025
@Mantisus Mantisus requested a review from Pijukatel October 23, 2025 14:55
@Mantisus Mantisus self-assigned this Oct 23, 2025
@Mantisus Mantisus marked this pull request as ready for review October 23, 2025 14:56
@Mantisus
Copy link
Collaborator Author

Mantisus commented Oct 23, 2025

It seems to be working. Several test runs failed, but this is not related to curl.

Copy link
Collaborator

@Pijukatel Pijukatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the skip from these tests to see if it works on them as well?
test_sitemap.test_gzipped_sitemap_with_invalid_data
test_http_clients.test_stream

@Mantisus Mantisus requested a review from Pijukatel October 24, 2025 09:00
@Pijukatel Pijukatel merged commit 36446a7 into apify:master Oct 24, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants