refactor!: Replace HttpxHttpClient with ImpitHttpClient as default HTTP client#1307
Merged
Conversation
Collaborator
Author
|
The cookie issue should be resolved in the next |
Pijukatel
approved these changes
Jul 24, 2025
vdusek
requested changes
Jul 25, 2025
vdusek
left a comment
vdusek
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, just a few comments 🙂.
Also, what now - are we gonna switch from httpx to impit in Apify Python Client? This will result in fewer dependencies in the SDK...
- SDK -> [Crawlee, Client]
- Crawlee -> Impit
- Client -> Impit
(No HTTPX in the minimal instalation.)
Collaborator
Author
That makes sense. But I've now checked the client code. Before replacing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HttpxHttpClientwithImpitHttpClientas default HTTP clientIssues
impitas HTTP client #1079