-
Notifications
You must be signed in to change notification settings - Fork 17
feat: Upgrade to Crawlee v0.5 #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7e853dd to
fa871b8
Compare
12256f3 to
89e28b6
Compare
89e28b6 to
18efd5d
Compare
18efd5d to
37a1adf
Compare
51be03d to
581e5d7
Compare
| from crawlee import service_container | ||
|
|
||
| cast(dict, service_container._services).clear() | ||
| def prepare_test_env(monkeypatch: pytest.MonkeyPatch, tmp_path: Path) -> Callable[[], None]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prepare_test_env is the same as in the Crawlee
| def _reset_and_patch_default_instances() -> None: | ||
| """Reset the used singletons and patch the default storage client with a temporary directory. | ||
| @pytest.fixture | ||
| def prepare_test_env(monkeypatch: pytest.MonkeyPatch, tmp_path: Path) -> Callable[[], None]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prepare_test_env is the same as in the Crawlee
581e5d7 to
2c6d513
Compare
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, see the suggestion 🙂
Co-authored-by: Jan Buchar <jan.buchar@apify.com>
Uh oh!
There was an error while loading. Please reload this page.