Skip to content

Conversation

@janbuchar
Copy link
Contributor

I could not find the actual reason why the linked run got stuck, but this should make the Actor cleanup more robust as a whole.

@janbuchar janbuchar requested a review from vdusek May 23, 2024 11:36
@janbuchar janbuchar requested a review from B4nan May 23, 2024 11:37
@github-actions github-actions bot added this to the 90th sprint - Tooling team milestone May 23, 2024
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label May 23, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

None of the pull request and linked issue has estimate

@janbuchar janbuchar requested a review from B4nan May 23, 2024 11:51
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, just please add the change description manually to the changelog

@janbuchar janbuchar requested a review from vdusek May 23, 2024 13:08
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@B4nan
Copy link
Member

B4nan commented May 23, 2024

please release this to stable afterwards

@janbuchar janbuchar merged commit cfed57d into master May 23, 2024
@janbuchar janbuchar deleted the actor-cleanup-timeout branch May 23, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correctly handle actor exit

4 participants