Skip to content

Actor.reboot method uses the new reboot endpoint #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 25, 2023
Merged

Actor.reboot method uses the new reboot endpoint #109

merged 9 commits into from
Aug 25, 2023

Conversation

@vdusek
Copy link
Contributor

@vdusek vdusek commented Aug 23, 2023

Issue

Description

Test plan

  • Reboot functionality cannot be tested locally, so it will have to be tested on the platform. I'll create some testing Actor and use the beta release of SDK once this PR is merged.

@vdusek vdusek requested a review from jirimoravcik August 23, 2023 14:02
fnesveda
fnesveda requested changes Aug 23, 2023
View reviewed changes
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small notes

@vdusek vdusek requested a review from fnesveda August 23, 2023 14:24
@vdusek
Copy link
Contributor Author

vdusek commented Aug 24, 2023

An integration test for the Actor reboot was added.

fnesveda
fnesveda requested changes Aug 24, 2023
View reviewed changes
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one suggestion for the test

@vdusek vdusek requested a review from fnesveda August 24, 2023 15:46
fnesveda
fnesveda requested changes Aug 24, 2023
View reviewed changes
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small nitpicks, sorry 😄

@vdusek vdusek requested a review from fnesveda August 25, 2023 06:30
fnesveda
fnesveda approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@vdusek vdusek merged commit fcb9d11 into master Aug 25, 2023
@vdusek vdusek deleted the reboot-uses-new-endpoint branch August 25, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jirimoravcik jirimoravcik jirimoravcik approved these changes

@fnesveda fnesveda fnesveda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Edit the .reboot() to use the new reboot endpoint

4 participants

@vdusek @jirimoravcik @fnesveda