Skip to content

chore: bump Docusaurus + React, use yarn #1615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

chore: bump Docusaurus + React, use yarn #1615

wants to merge 8 commits into from

Conversation

barjin
Copy link
Contributor

@barjin barjin commented Jun 3, 2025 •
edited
Loading

Bumps Docusaurus to 3.8.0 and React to version 19. Switches the package manager to yarn because of faulty version resolution with npm.

@barjin barjin self-assigned this Jun 3, 2025
@barjin barjin added the adhoc Ad-hoc unplanned task added during the sprint. label Jun 3, 2025
@barjin barjin force-pushed the bump/react-docusaurus branch from bdf2e52 to deffb20 Compare June 3, 2025 07:58
@apify-service-account
Copy link

Preview for this PR was built for commit bdf2e525 and is ready at https://pr-1615.preview.docs.apify.com!

@github-actions github-actions bot added this to the 116th sprint - Tooling team milestone Jun 3, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Jun 3, 2025
@apify-service-account
Copy link

Preview for this PR was built for commit deffb20e and is ready at https://pr-1615.preview.docs.apify.com!

@barjin barjin force-pushed the bump/react-docusaurus branch 2 times, most recently from ca8e9e5 to a12fa45 Compare June 3, 2025 08:59
@apify-service-account
Copy link

Preview for this PR was built for commit a12fa452 and is ready at https://pr-1615.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit 295670ed and is ready at https://pr-1615.preview.docs.apify.com!

@barjin
Copy link
Contributor Author

barjin commented Jun 3, 2025

While the update seems to work with npm run build, it breaks npm run start(:dev) (see here)

image

npm + rspack don't resolve the correct version of micromark-util-symbol and try to call its 1.0 API on the 2.0 package.

Weirdly enough, this doesn't seem to be the problem with yarn with node-modules linker.

@barjin barjin force-pushed the bump/react-docusaurus branch from 45b5c32 to 50665c2 Compare June 3, 2025 12:30
@barjin barjin marked this pull request as ready for review June 3, 2025 12:40
@barjin barjin mentioned this pull request Jun 3, 2025
Closed
@barjin barjin requested a review from B4nan June 5, 2025 11:52
@barjin barjin changed the title chore: bump docusaurus + React chore: bump Docusaurus + React, use yarn Jun 5, 2025
@vladfrangu
Copy link
Member

Btw if we're moving this repository to yarn, the docs-private flow also needs to be moved to it, otherwise you'll get WILD issues that make no sense

@B4nan
Copy link
Member

B4nan commented Jun 9, 2025

@vladfrangu could you take a look locally too to see if we can stay on NPM? I'll try to do the same later today or tomorrow, feels weird that the module resolution wouldn't work like this. Maybe we just need to use overrides or add some dependency explicitly somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B4nan B4nan Awaiting requested review from B4nan

At least 1 approving review is required to merge this pull request.

Assignees

@barjin barjin

Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
116th sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
4 participants
@barjin @apify-service-account @vladfrangu @B4nan