feat: add maxTotalChargeUsd param #1485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TC-MO
requested changes
Mar 4, 2025
TC-MO
approved these changes
Mar 4, 2025
Comment on lines
+215
to
+219
| Specifies the maximum cost of the task run. This parameter is | ||
| useful for pay-per-event tasks, as it allows you to limit the amount | ||
| charged to your subscription. You can access the | ||
| maximum cost in your Actor by using the | ||
| `ACTOR_MAX_TOTAL_CHARGE_USD` environment variable. |
There was a problem hiding this comment.
Should we refer to it as pay-per-event task? Correct me if I'm wrong but only Actor can be pay-per-event and task inherently have no monetization but they can be comprised of Actors right?
Maybe something like:
Suggested change
| Specifies the maximum cost of the task run. This parameter is | |
| useful for pay-per-event tasks, as it allows you to limit the amount | |
| charged to your subscription. You can access the | |
| maximum cost in your Actor by using the | |
| `ACTOR_MAX_TOTAL_CHARGE_USD` environment variable. | |
| Specifies the maximum cost of the task run. This parameter is | |
| useful when using pay-per-event Actors, as it allows you to limit the amount | |
| charged to your subscription. You can access the | |
| maximum cost in your Actor by using the | |
| `ACTOR_MAX_TOTAL_CHARGE_USD` environment variable. |
There was a problem hiding this comment.
We say This is useful for pay-per-result tasks, for maxItems above so I've changed it to fit the context.
There was a problem hiding this comment.
Let's leave it for now, but I might revisit it later.
Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
maxTotalChargeUsdparam is missing in API doc. I've searched forACTOR_MAX_PAID_DATASET_ITEMSand added info aboutmaxTotalChargeUsdto all relevant places.