Skip to content

chore: Deal with threading related issues that caused flakinnes #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2025
Merged

chore: Deal with threading related issues that caused flakinnes #420

merged 1 commit into from
Jun 13, 2025

Conversation

Pijukatel
Copy link
Contributor

@Pijukatel Pijukatel commented Jun 13, 2025 •
edited
Loading

  • Add lock to prevent access to already running generator
  • Compare sets to avoid order related non determinism caused by threads

@Pijukatel
Deal with threading related issues that caused flakinnes
cbbb1c5 
- Add lock to prevent acces to already running generator
- Compare sets to avoid order related non determinism caused by threads
@github-actions github-actions bot added this to the 116th sprint - Tooling team milestone Jun 13, 2025
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Jun 13, 2025
@Pijukatel Pijukatel requested a review from vdusek June 13, 2025 13:07
@Pijukatel Pijukatel marked this pull request as ready for review June 13, 2025 13:07
@Pijukatel Pijukatel added the adhoc Ad-hoc unplanned task added during the sprint. label Jun 13, 2025
vdusek
vdusek approved these changes Jun 13, 2025
View reviewed changes
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@Pijukatel Pijukatel merged commit 7a1c618 into master Jun 13, 2025
29 of 30 checks passed
@Pijukatel Pijukatel deleted the improve-log-redirect-test-stability branch June 13, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdusek vdusek vdusek approved these changes

Assignees

@Pijukatel Pijukatel

Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Milestone
116th sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
2 participants
@Pijukatel @vdusek