Skip to content

feat: add support for general resource access #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025

Conversation

tobice
Copy link
Contributor

@tobice tobice commented Apr 28, 2025

We plan to allow users to configure through API & clients how their storages and runs can be accessed — whether just the ID / name is sufficient to access the storage. This is controlled through the general_access resource property, which overrides account setting for the resource.

Full context in https://github.com/apify/apify-core/issues/19012.

This PR updates the client so that it can be used to get and update general access on datasets, key-value stores, request queues, and runs.

client = ApifyClient(token=API_TOKEN)

# Set general access to ANYONE_WITH_ID_CAN_READ which overrides the account setting.
client.dataset(dataset_id).update(
    general_access=StorageGeneralAccess.ANYONE_WITH_ID_CAN_READ
)

@tobice tobice requested review from vdusek and danpoletaev April 28, 2025 12:57
@tobice tobice self-assigned this Apr 28, 2025
@github-actions github-actions bot added this to the 113th sprint - Platform team milestone Apr 28, 2025
@github-actions github-actions bot added the t-platform Issues with this label are in the ownership of the platform team. label Apr 28, 2025
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please use the new version of uv and regenerate the lock file (you're removing the upload_time fields)? 🙂

@tobice
Copy link
Contributor Author

tobice commented Apr 28, 2025

Done 👍

@tobice tobice requested a review from vdusek April 28, 2025 13:26
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobice tobice merged commit cc79c30 into master Apr 29, 2025
28 checks passed
@tobice tobice deleted the tobik/feat/add-support-for-general-resource-access branch April 29, 2025 06:22
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-platform Issues with this label are in the ownership of the platform team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants