Skip to content

feat: add rate limit statistics #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 4, 2025
Merged

feat: add rate limit statistics #343

merged 7 commits into from
Feb 4, 2025

Conversation

Mantisus
Copy link
Collaborator

Description

  • Add Statistics for gather HTTP rate limit errors
  • Linked Issues is in the sdk, but the implementation should be in the client

Issues

Testing

  • Add tests for Statistics

@Mantisus Mantisus had a problem deploying to fork-pr-integration-tests January 31, 2025 09:19 — with GitHub Actions Failure
@Mantisus Mantisus requested review from janbuchar and vdusek February 3, 2025 13:04
vdusek
vdusek reviewed Feb 3, 2025
View reviewed changes
@Mantisus @vdusek
Update src/apify_client/_statistics.py
d95b7c8 
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
@Mantisus Mantisus had a problem deploying to fork-pr-integration-tests February 3, 2025 13:38 — with GitHub Actions Failure
@Mantisus Mantisus requested a review from vdusek February 3, 2025 15:30
@Mantisus Mantisus had a problem deploying to fork-pr-integration-tests February 3, 2025 16:13 — with GitHub Actions Failure
@Mantisus Mantisus had a problem deploying to fork-pr-integration-tests February 4, 2025 09:41 — with GitHub Actions Failure
janbuchar
janbuchar approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, feel free to merge when @vdusek approves 🙂

vdusek
vdusek approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mantisus Mantisus had a problem deploying to fork-pr-integration-tests February 4, 2025 10:45 — with GitHub Actions Failure
@vdusek vdusek merged commit f35c68f into apify:master Feb 4, 2025
26 of 27 checks passed
@vdusek vdusek added this to the 107th sprint - Tooling team milestone Feb 4, 2025
@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. enhancement New feature or request. labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janbuchar janbuchar janbuchar approved these changes

@vdusek vdusek vdusek approved these changes

Assignees

@Mantisus Mantisus

Labels
enhancement New feature or request. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
107th sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
3 participants
@Mantisus @janbuchar @vdusek