Skip to content

feat: add GET: dataset.statistics #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2025
Merged

feat: add GET: dataset.statistics #324

merged 1 commit into from
Jan 7, 2025

Conversation

MFori
Copy link
Member

@MFori MFori commented Jan 1, 2025 •
edited
Loading

Part of https://github.com/apify/apify-core/issues/18807 - Implementation of new API endpoint v2/datasets/{datasetId}/statistics

@MFori MFori added the t-console Issues with this label are in the ownership of the console team. label Jan 1, 2025
@MFori MFori self-assigned this Jan 1, 2025
@MFori MFori requested a review from vdusek January 6, 2025 15:37
@MFori MFori marked this pull request as ready for review January 6, 2025 15:37
@vdusek vdusek requested a review from Pijukatel January 6, 2025 15:47
Pijukatel
Pijukatel reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@Pijukatel Pijukatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to add some basic test for this.

@MFori
Copy link
Member Author

MFori commented Jan 7, 2025

I would suggest to add some basic test for this.

@Pijukatel Sorry I don't write python often, but in js-client we have ready set of tests, for testing that just the right API endpoint is called, but I don't see any similar setup in this repo. The actual endpoint integration tests are in apify-core so I don't think it's necessary to test functioning of API endpoint again here.

@vdusek
Copy link
Contributor

vdusek commented Jan 7, 2025

@Pijukatel Sorry I don't write python often, but in js-client we have ready set of tests, for testing that just the right API endpoint is called, but I don't see any similar setup in this repo. The actual endpoint integration tests are in apify-core so I don't think it's necessary to test functioning of API endpoint again here.

We currently do not have any testing framework here, so we will have to leave it at that for now.

vdusek
vdusek approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@vdusek vdusek merged commit 19ea4ad into master Jan 7, 2025
29 checks passed
@vdusek vdusek deleted the feat/dataset-statistics-endpoint branch January 7, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdusek vdusek vdusek approved these changes

@Pijukatel Pijukatel Pijukatel approved these changes

Assignees

@MFori MFori

Labels
t-console Issues with this label are in the ownership of the console team.
Projects
None yet
Milestone
105th sprint - Console team - Christmas
Development

Successfully merging this pull request may close these issues.
3 participants
@MFori @vdusek @Pijukatel