Skip to content

feat: add user.update_limits #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2024
Merged

feat: add user.update_limits #279

merged 2 commits into from
Oct 24, 2024

Conversation

MFori
Copy link
Member

@MFori MFori commented Oct 23, 2024

Resolves apify/apify-client-js#329 - add update_limits function to UserClient, which does PUT: /v2/users/:userId/limits
Api docs PR here: apify/openapi#103
Client JS PR here: apify/apify-client-js#595
Console api docs PR here: https://github.com/apify/apify-core/pull/18038
Endpoint is already implemented, only api docs and clients were missing

@MFori MFori added the t-console Issues with this label are in the ownership of the console team. label Oct 23, 2024
@MFori MFori requested review from tobice and drobnikj October 23, 2024 12:09
@MFori MFori self-assigned this Oct 23, 2024
@github-actions github-actions bot added this to the 101st sprint - Console team milestone Oct 23, 2024
Copy link
Contributor

@tobice tobice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I don't read / write Python that often. It'd be good to get the approval from somebody who does. Looking at the history @barjin or @vdusek might be good candidates.

@MFori MFori requested a review from barjin October 23, 2024 12:53
@barjin barjin requested review from vdusek and removed request for barjin October 23, 2024 13:11
@barjin
Copy link
Contributor

barjin commented Oct 23, 2024

Sorry guys, I'm not the Python dev in our team 😅 the commits are likely from my work on the documentation. Python goes after @vdusek and @janbuchar (I already pinged Vlada) 🐍

Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdusek vdusek merged commit 7aed9c9 into master Oct 24, 2024
26 checks passed
@vdusek vdusek deleted the feat/user-update-limits branch October 24, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-console Issues with this label are in the ownership of the console team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add endpoints for user limits and usage
4 participants