Switch project setup to pyproject.toml #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnesveda
added
adhoc
jirimoravcik
approved these changes
May 5, 2023
fnesveda
added
the
validated
fnesveda
added a commit
to apify/apify-sdk-python
that referenced
this pull request
May 23, 2023
Basically the same as apify/apify-client-python#123. Since we're hiring a new Python engineer hopefully soon, I thought it's time to get rid of some tech debt. This rewrites the project setup to use pyproject.toml instead of setup.py, as pyproject.toml is the modern, recommended way to specify project metadata, and setup.py is being deprecated. I've also updated the publication to PyPI to use the official GitHub action, and to use OIDC for authentication instead of an API token. And I've switched the secrets for building Python Actor base Docker images to use an org-wide GitHub token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're hiring a new Python engineer hopefully soon, I thought it's time to get rid of some tech debt.
This rewrites the project setup to use
pyproject.tomlinstead ofsetup.py, aspyproject.tomlis the modern, recommended way to specify project metadata, andsetup.pyis being deprecated.I've also updated the publication to PyPI to use the official GitHub action, and to use OIDC for authentication instead of an API token.