Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add exponential backoff to batchAddRequests, untie batch and client settings #243

Merged
merged 8 commits into from
May 12, 2022

Conversation

jirimoravcik
Copy link
Member

No description provided.

@jirimoravcik jirimoravcik added the medium priority Medium priority issues to be done in a couple of sprints. label May 5, 2022
@github-actions github-actions bot added this to the 37th sprint - Platform team milestone May 5, 2022
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just had a few improvement ideas.

src/resource_clients/request_queue.ts Outdated Show resolved Hide resolved
src/resource_clients/request_queue.ts Outdated Show resolved Hide resolved
jirimoravcik and others added 3 commits May 6, 2022 11:57
Co-authored-by: František Nesveda <fnesveda@users.noreply.github.com>
…com:apify/apify-client-js into feature/rq-batch-insert-exponential-backoff
@jirimoravcik
Copy link
Member Author

jirimoravcik commented May 6, 2022

Check the commits 0479444 and small fix 353f38b

It is inspired by https://github.com/rxaviers/async-pool/blob/1.x/lib/es7.js

@jirimoravcik jirimoravcik requested a review from fnesveda May 6, 2022 12:03
Copy link
Member

@valekjo valekjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jirimoravcik jirimoravcik changed the title feat: Add exponential backoff to batchAddRequests, untie batch and client settings fix: Add exponential backoff to batchAddRequests, untie batch and client settings May 11, 2022
@jirimoravcik jirimoravcik merged commit 3b5563b into master May 12, 2022
@jirimoravcik jirimoravcik deleted the feature/rq-batch-insert-exponential-backoff branch May 12, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium priority Medium priority issues to be done in a couple of sprints.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants