Repository navigation
add support infinite scroll, initial cookies - #3
Merged
Merged
Conversation
initial cookies: fix null value
mtrunkat
requested changes
Nov 30, 2017
| */ | ||
| export const infiniteScroll = async (page, maxHeight) => { | ||
| const maybeResourceTypesInfiniteScroll = ['xhr', 'fetch', 'websocket', 'other']; | ||
| const scrollTo = (page, xpos, ypos) => page.evaluate((x, y) => window.scrollTo(x, y), xpos, ypos); |
Member
There was a problem hiding this comment.
Maybe move getPageScrollInfo and scrollTo to puppeteer_utils.js . It's reusable.
| if (maybeResourceTypesInfiniteScroll.includes(msg.resourceType)) resourcesStats.finished++; | ||
| }); | ||
|
|
||
| console.log(`Infinite scroll started (scrollTop=${scrollInfo.scrollTop}, clientHeight=${scrollInfo.clientHeight}, scrollHeight=${scrollInfo.scrollHeight}, maxHeight=${maxHeight}).`); |
Member
There was a problem hiding this comment.
What about to put logging to function -
(scrollTop=${scrollInfo.scrollTop}, clientHeight=${scrollInfo.clientHeight}, scrollHeight=${scrollInfo.scrollHeight}, maxHeight=${maxHeight})
- is three times here
| if (maybeResourceTypesInfiniteScroll.includes(msg.resourceType)) resourcesStats.finished++; | ||
| }); | ||
|
|
||
| console.log(`Infinite scroll started (scrollTop=${scrollInfo.scrollTop}, clientHeight=${scrollInfo.clientHeight}, scrollHeight=${scrollInfo.scrollHeight}, maxHeight=${maxHeight}).`); |
Member
There was a problem hiding this comment.
Use logDebug here so that it's not displayed when running in production env
…scroll exceptions
mtrunkat
approved these changes
Dec 4, 2017
janbuchar
pushed a commit
that referenced
this pull request
Nov 13, 2025
add support infinite scroll, initial cookies
janbuchar
pushed a commit
that referenced
this pull request
Nov 13, 2025
add support infinite scroll, initial cookies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.