This repository was archived by the owner on Nov 8, 2024. It is now read-only.
Handle required schema object keys which are not in properties #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylef
force-pushed
the
kylef/oas2-required
branch
from
f784a04 to
02afaa3
Compare
opichals
approved these changes
May 12, 2020
| member.attributes.set('typeAttributes', ['required']); | ||
| return member; | ||
| }); | ||
| element.content = element.content.concat(requiredMembers); |
There was a problem hiding this comment.
Suggested change
| element.content = element.content.concat(requiredMembers); | |
| element.content.push(...requiredMembers); |
There was a problem hiding this comment.
Added 6457f33 which does the same for the other two cases in this file.
There was a problem hiding this comment.
and thanks, I didn't think of doing it like that
kylef
force-pushed
the
kylef/oas2-required
branch
from
02afaa3 to
6457f33
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the OAS 2 parser losses information about required keys which are not found in properties. For example in the following schema:
Would produce an object element with no keys. With this patch we created the member element which contains the key and the required type attribute.