Skip to content
This repository was archived by the owner on Nov 8, 2024. It is now read-only.

Conversation

kylef
Copy link
Member

@kylef kylef commented Jan 25, 2018

This PR adds the base Sphinx documentation with installation and basic usage. This is an MVP. I have full API reference and documentation to publish, I will incrementally PR the separate changes.

messages image 1270598827

@kylef kylef requested a review from tjanc January 25, 2018 15:45
@@ -0,0 +1,142 @@
#!/usr/bin/env python3
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is mostly generated directly from Sphinx project generator.

@Almad
Copy link

Almad commented Jan 26, 2018

Just a note that anywhere else, we are AFAIK consistently using RTD theme. Any reason for preference for Alabaster?

@kylef
Copy link
Member Author

kylef commented Jan 26, 2018

Just a note that anywhere else, we are AFAIK consistently using RTD theme. Any reason for preference for Alabaster?

@Almad It's the default theme for Sphinx so that's the biggest reason, I just simply did not change it.

I do think Alabaster looks cleaner however, and Alabaster uses a font which is a bit more readable. I've used this on pretty much every Sphinx site I've created (https://swiftenv.fuller.li/en/latest/, https://stencil.fuller.li/en/latest/, https://curassow.fuller.li/en/latest/). The other theme is also left aligned and doesn't work well on all display sizes:

messages image 34680763

However, I can change this for consistency with Dredd documentation.

@tjanc tjanc merged commit 541f059 into master Jan 29, 2018
@kylef kylef deleted the kylef/sphinx branch January 29, 2018 12:18
@Almad
Copy link

Almad commented Mar 27, 2018

@kylef I think we should go with consistency. Open to which theme we should use—probably something for brainstorm and/or team lead sync.

Also //cc @michalholasek @w-vi @abtris

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants