feat: make saml protocol binding method configurable #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
Signed-off-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
| if samls[sp_issuer] == nil then | ||
| local kc = require("lib.keycloak") | ||
| local opts = setmetatable({sp_issuer = sp_issuer}, {__index = kc.get_default_opts()}) | ||
| opts.auth_protocol_binding_method = "HTTP-POST" |
Contributor
Author
There was a problem hiding this comment.
uses post
Signed-off-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
| } | ||
| --- error_code: 200 | ||
| --- error_log | ||
| login callback req with http post |
Contributor
Author
There was a problem hiding this comment.
assert method
| } | ||
| --- error_code: 200 | ||
| --- error_log | ||
| login callback req with redirect |
Contributor
Author
There was a problem hiding this comment.
assert method
Signed-off-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
nic-6443
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using saml auth with azure AD, it was found that protocol binding with
HTTP-GETis not supported.Thus we need to make protocol binding configurable.
Once that is done, integration with Azure AD still failed because the browser would block from cookie header being sent since the default value of
samesite=Laxwill come into play. Hence, when protocol binding method is set toHTTP-POST, samesite should set to be None and secure to true.