Update non-major-dev-dependencies #367

renovate · 2024-08-12T01:48:51Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
@nomicfoundation/hardhat-ethers (source)	`^3.0.6` -> `^3.0.8`
@total-typescript/ts-reset (source)	`^0.5.1` -> `^0.6.1`
@types/node (source)	`^20.14.14` -> `^20.16.3`
eslint-plugin-import	`^2.29.1` -> `^2.30.0`
eslint-plugin-jest	`^28.7.0` -> `^28.8.2`
hardhat (source)	`^2.22.8` -> `^2.22.10`
husky	`^9.1.4` -> `^9.1.5`
ts-jest (source)	`^29.2.4` -> `^29.2.5`

Release Notes

nomicfoundation/hardhat (@nomicfoundation/hardhat-ethers)

`v3.0.8`

Compare Source

A small bug fix release to fix the Hardhat peer dependency entry in the published package.json that was corrupted by pnpm in the previous release.

Changes

efa905d: Fix for corrupted Hardhat peer dependency version from pnpm.

💡 The Nomic Foundation is hiring! Check our open positions.

`v3.0.7`

Compare Source

A small bug fix release to help when running against Erigon where the eth_accounts RPC call is deprecated.

Changes

93b30d5: Fix for getSigners against networks where eth_accounts is deprecated.

💡 The Nomic Foundation is hiring! Check our open positions.

total-typescript/ts-reset (@total-typescript/ts-reset)

`v0.6.1`

Patch Changes

757be40: Fixed a bug where creating an empty map would no longer infer types correctly.

`v0.6.0`

Minor Changes

6574858: Added a rule, /map-constructor, to default Map to Map<unknown, unknown> when no arguments are passed to the constructor.

Before, you'd get any for both key and value types. Now, the result of Map.get is unknown instead of any:
```
const userMap = new Map();

const value = userMap.get("matt"); // value: unknown
```
This now is part of the recommended rules.

5bf3a15: Added a rule, /promise-catch, to change the catch method to take unknown instead of any as an argument.

const promise = Promise.reject("error");

// BEFORE

promise.catch((error) => {
  console.error(error); // error is any!
});

// AFTER

promise.catch((error) => {
  console.error(error); // error is unknown!
});

Patch Changes

53cee4f: author: @none23

Fixed a bug where running .filter on a union of arrays would not work.

import-js/eslint-plugin-import (eslint-plugin-import)

`v2.30.0`

Compare Source

Added

[dynamic-import-chunkname]: add allowEmpty option to allow empty leading comments ([#2942], thanks [@JiangWeixian])
[dynamic-import-chunkname]: Allow empty chunk name when webpackMode: 'eager' is set; add suggestions to remove name in eager mode ([#3004], thanks [@amsardesai])
[no-unused-modules]: Add ignoreUnusedTypeExports option ([#3011], thanks [@silverwind])
add support for Flat Config ([#3018], thanks [@michaelfaith])

Fixed

[no-extraneous-dependencies]: allow wrong path ([#3012], thanks [@chabb])
[no-cycle]: use scc algorithm to optimize ([#2998], thanks [@soryy708])
[no-duplicates]: Removing duplicates breaks in TypeScript ([#3033], thanks [@yesl-kim])
[newline-after-import]: fix considerComments option when require ([#2952], thanks [@developer-bandi])
[order]: do not compare first path segment for relative paths ([#2682]) ([#2885], thanks [@mihkeleidast])

Changed

[Docs] no-extraneous-dependencies: Make glob pattern description more explicit ([#2944], thanks [@mulztob])
[no-unused-modules]: add console message to help debug [#2866]
[Refactor] ExportMap: make procedures static instead of monkeypatching exportmap ([#2982], thanks [@soryy708])
[Refactor] ExportMap: separate ExportMap instance from its builder logic ([#2985], thanks [@soryy708])
[Docs] order: Add a quick note on how unbound imports and --fix ([#2640], thanks [@minervabot])
[Tests] appveyor -> GHA (run tests on Windows in both pwsh and WSL + Ubuntu) ([#2987], thanks [@joeyguerra])
[actions] migrate OSX tests to GHA ([ljharb#37], thanks [@aks-])
[Refactor] exportMapBuilder: avoid hoisting ([#2989], thanks [@soryy708])
[Refactor] ExportMap: extract "builder" logic to separate files ([#2991], thanks [@soryy708])
[Docs] [order]: update the description of the pathGroupsExcludedImportTypes option ([#3036], thanks [@liby])
[readme] Clarify how to install the plugin ([#2993], thanks [@jwbth])

jest-community/eslint-plugin-jest (eslint-plugin-jest)

`v28.8.2`

Compare Source

Performance Improvements

prefer-importing-jest-globals: stop collecting import specifiers for no reason (#1646) (0660242)

`v28.8.1`

Compare Source

Bug Fixes

prefer-importing-jest-globals: support typescript-eslint parser (#1639) (307f6a7)

`v28.8.0`

Compare Source

Features

import formatting rules from eslint-plugin-jest-formatting (#1563) (74078ee)

nomiclabs/hardhat (hardhat)

`v2.22.10`: Hardhat v2.22.10

Compare Source

This is a small bug fix release to improve debug logs during Hardhat Network initialization.

Changes

409e99f: Fixed debug logs in Hardhat Network initialization process.
46cd7a1: Removed the experimentalAddHardhatNetworkMessageTraceHook API

💡 The Nomic Foundation is hiring! Check our open positions.

`v2.22.9`: Hardhat v2.22.9

Compare Source

This is a small bug fix release remove a warning message against the local Hardhat node when deploying with Hardhat Ignition.

Changes

6771f00: Do not send http_setLedgerOutputEnabled messages beyond the HTTP Provider to prevent unwanted warnings in the logs of the local hardhat node

💡 The Nomic Foundation is hiring! Check our open positions.

typicode/husky (husky)

`v9.1.5`

Compare Source

kulshekhar/ts-jest (ts-jest)

`v29.2.5`

Compare Source

Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Siegrift · 2024-08-12T11:59:43Z

package.json

@@ -57,12 +57,7 @@
    "@total-typescript/ts-reset": "^0.5.1",
    "@types/jest": "^29.5.12",
    "@types/lodash": "^4.17.7",
-    "@types/node": "^20.14.14",


I've removed the ESLint dependencies because they should be downloaded by installing the @api3/commons-eslint package. This doesn't seem to break anything so I think it's fine.

Except CI failed linting 🙁 Looks to because of new jest formatting rules in v28.8.0 of eslint-plugin-jest.

dcroote

Since all the new rules referenced above were all fixable with --fix I went ahead and applied those, but I imagine we'd have to apply the fix for every repo we have, so we could also decide to disable padding-around-all upstream in our eslint-plugin-commons.

bdrhn9 · 2024-09-03T14:55:31Z

src/update-feeds-loops/update-feeds-loops.ts

-              else resolve(result);
-            });
-          }),
+          (async (): Promise<Awaited<ReturnType<typeof processBatch>>> => {


I made these changes in response to an issue caused by upgrading @total-typescript/ts-reset from version 0.5.1 to 0.6.1, which resulted in TypeScript compilation errors. The update introduced stricter type-checking that required a more explicit approach to handling types and promises.

This immediately invoked function approach also improves code readability.

TBH: I'm not a huge fan of IIFE in regards to readability.

I see. So, would you prefer to use previous approach or do you have better suggestion on this? I can change this.

Nah, I think it's not worth to change this. I think I'd prefer the previous approach (but not sure what was the TS issue there).

I mostly wanted express my opinion on that.

but not sure what was the TS issue there

The error was for this part:

error: src/update-feeds-loops/update-feeds-loops.ts:230:45 - error TS2349: This expression is not callable. Each member of the union type '{ <TResult1 = { signedApiUrlsFromConfig: string[]; signedApiUrlsFromContract: string[]; beaconIds: 0x${string}[]; successCount: number; errorCount: number; }, TResult2 = never>(onfulfilled?: ((value: { signedApiUrlsFromConfig: string[]; signedApiUrlsFromContract: string[]; beaconIds: 0x${string}[]; successCount:...' has signatures, but none of those signatures are compatible with each other. 230 return processFirstBatchPromise.then((result) => { ~~~~ src/update-feeds-loops/update-feeds-loops.ts:230:51 - error TS7006: Parameter 'result' implicitly has an 'any' type. 230 return processFirstBatchPromise.then((result) => { ~~~~~~

Mhh, strange. Just from the looks of it I don't know what is wrong. But I think you're solution is good OK, so wouldn't bother investigating further.

bdrhn9 · 2024-09-03T14:56:35Z

src/update-feeds-loops/update-feeds-loops.ts

@@ -183,7 +183,7 @@ export const runUpdateFeeds = async (providerName: string, chain: Chain, chainId
          provider,
          chainId,
          firstBatchBlockNumber
-        ).catch((error) => error);
+        ).catch((error: any) => error);


In new version 0.6.1 of @total-typescript/ts-reset, catch resolves output as unknown rather than any.

renovate bot requested a review from Siegrift August 12, 2024 01:48

renovate bot force-pushed the renovate/non-major-dev-dependencies branch from e5e734e to 7424637 Compare August 12, 2024 11:45

Siegrift force-pushed the renovate/non-major-dev-dependencies branch from e4a4f31 to f4c1ac5 Compare August 12, 2024 11:54

Siegrift requested a review from dcroote August 12, 2024 11:58

Siegrift reviewed Aug 12, 2024

View reviewed changes

dcroote approved these changes Aug 13, 2024

View reviewed changes

Update non-major-dev-dependencies

b7d8e4d

renovate bot force-pushed the renovate/non-major-dev-dependencies branch from 50d9f5d to b7d8e4d Compare September 3, 2024 09:06

renovate bot requested a review from bdrhn9 September 3, 2024 13:44

bdrhn9 added 2 commits September 3, 2024 17:49

Utilize immediately invoked function for promise handling

64df5ec

Run eslint

d6dc22d

bdrhn9 reviewed Sep 3, 2024

View reviewed changes

bdrhn9 merged commit f36505e into main Sep 3, 2024
4 checks passed

bdrhn9 deleted the renovate/non-major-dev-dependencies branch September 3, 2024 14:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update non-major-dev-dependencies #367

Update non-major-dev-dependencies #367

renovate bot commented Aug 12, 2024 •

edited

Loading

Siegrift Aug 12, 2024

dcroote Aug 13, 2024 •

edited

Loading

dcroote left a comment

bdrhn9 Sep 3, 2024

Siegrift Sep 3, 2024

bdrhn9 Sep 3, 2024

Siegrift Sep 3, 2024

Siegrift Sep 3, 2024

bdrhn9 Sep 3, 2024

Siegrift Sep 4, 2024

bdrhn9 Sep 3, 2024

Update non-major-dev-dependencies #367

Update non-major-dev-dependencies #367

Conversation

renovate bot commented Aug 12, 2024 • edited Loading

Release Notes

Changes

Changes

Patch Changes

Minor Changes

Patch Changes

Added

Fixed

Changed

Performance Improvements

Bug Fixes

Features

v2.22.10: Hardhat v2.22.10

Changes

v2.22.9: Hardhat v2.22.9

Changes

Configuration

Choose a reason for hiding this comment

dcroote Aug 13, 2024 • edited Loading

Choose a reason for hiding this comment

dcroote left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

renovate bot commented Aug 12, 2024 •

edited

Loading

`v2.22.10`: Hardhat v2.22.10

`v2.22.9`: Hardhat v2.22.9

dcroote Aug 13, 2024 •

edited

Loading