fix(metadata): fix losing content on error reponse with no output #7674
+41
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
VincentLanglet
commented
Jan 14, 2026
VincentLanglet
commented
| Q | A |
|---|---|
| Branch? | 4.2 |
| Tickets | Closes #7664 |
| License | MIT |
| Doc PR | api-platform/docs#... |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where error responses incorrectly lose content when an operation has no output configured (output: false). The fix ensures that error responses always include their content schemas, even when the main operation response is configured to have no output.
Changes:
- Modified
buildOpenApiResponseto accept anisErrorResponseparameter to distinguish error responses from regular responses - Updated the
noOutputlogic to only apply to non-error responses
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/OpenApi/Factory/OpenApiFactory.php | Added isErrorResponse parameter to prevent error responses from incorrectly inheriting noOutput behavior |
| src/OpenApi/Tests/Factory/OpenApiFactoryTest.php | Added test case for operations with output: false to verify error responses retain their content |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
soyuka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.