feat(symfony): allow disabling PHPStan PhpDocParser#7507
Merged
soyuka merged 1 commit intoapi-platform:4.1from Nov 7, 2025
Merged
feat(symfony): allow disabling PHPStan PhpDocParser#7507soyuka merged 1 commit intoapi-platform:4.1from
soyuka merged 1 commit intoapi-platform:4.1from
Conversation
PHP docblocks may be used for internal documentation only, so exposing the details may leak internal information. Another issue is that PHPStan may be available only on debug environment, thus creating different behaviour when deploying an application in production. By default is enabled to avoid breaking changes.
soyuka
force-pushed
the
optional_php_docs
branch
from
67775c3 to
a6ef6c0
Compare
Member
|
I agree that leaking information is not great and I'd like to merge this as a bug fix indeed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP docblocks may be used for internal documentation only, so exposing
the details may leak internal information.
Another issue is that PHPStan may be available only on debug
environment, thus creating different behaviour when deploying an
application in production.
By default is enabled to avoid breaking changes.
Note: this is a bug from out point of view (since we found "leaking" internal information), but may be seen as a new feature since it's a new option. I'll wait for your feedback for changing description, docs & co