feat(laravel): boolean filter#6806
Conversation
|
Could you add a test (like https://github.com/api-platform/core/blob/main/src/Laravel/Tests/Eloquent/Filter/DateFilterTest.php)? |
|
There were missing a few things, I've added a test and registered the filter (https://github.com/api-platform/core/pull/6806/files#diff-1f34d8685c9bbcc2037ef47c41cb6dac916a0fe6fc06e2047b9635e35fa13527R423) I'll rebase this later. As you can see adding a functional test really helped to check it's working properly. |
Thanks for the feedback |
soyuka
force-pushed
the
boolean_filter
branch
from
9a0e008 to
530f030
Compare
|
needs #6860 |
soyuka
force-pushed
the
boolean_filter
branch
from
530f030 to
430abed
Compare
soyuka
force-pushed
the
boolean_filter
branch
from
430abed to
f1448fb
Compare
|
thanks @adryyy10! |
* feat: Adding boolean filter * refactor: return early if wrong values * tests: boolean filter test * refactor(BooleanFilter): cs fixer * add test --------- Co-authored-by: adriafigueres <adria.figueres@m10c.com> Co-authored-by: soyuka <soyuka@users.noreply.github.com>
|
@adryyy10, could you please add a documentation PR for this feature, targeting the Check our CONTRIBUTING Guide and do not hesitate if you need help. |
* feat: Adding boolean filter * refactor: return early if wrong values * tests: boolean filter test * refactor(BooleanFilter): cs fixer * add test --------- Co-authored-by: adriafigueres <adria.figueres@m10c.com> Co-authored-by: soyuka <soyuka@users.noreply.github.com>
4 participants
Adding new boolean filter in order to filter by boolean attributes