feat(elasticsearch): filtering on nested fields #5820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonnyeom
force-pushed
the
fix-nested-fields-3.1
branch
from
80af82e to
da31df4
Compare
soyuka
approved these changes
Sep 14, 2023
soyuka
changed the title
|
Thanks @jonnyeom |
|
I think that this actually breaks elasticsearch test suite my bad. |
soyuka
reviewed
Sep 15, 2023
| @@ -69,7 +69,7 @@ private function getNestedFieldPath(string $resourceClass, string $property): ?s | |||
| ) { | |||
| $nestedPath = $this->getNestedFieldPath($nextResourceClass, implode('.', $properties)); | |||
|
|
|||
| return null === $nestedPath ? $nestedPath : "$currentProperty.$nestedPath"; | |||
| return null === $nestedPath ? $currentProperty : "$currentProperty.$nestedPath"; | |||
There was a problem hiding this comment.
@jonnyeom I have to revert this to make https://github.com/api-platform/core/blob/main/features/elasticsearch/match_filter.feature#L120 green any idea? more at #5823
There was a problem hiding this comment.
interesting.
Let me take a deeper look again.
Thanks for heads up!
soyuka
added a commit
that referenced
this pull request
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a resurrection of #5643
This PR implements the following changes to support filtering on paths like foo.bar.baz:
foois an object,isNestedField()now returnstrueinstead offalsefoois an object,getNestedFieldPath()now returns"foo.bar"instead ofnullfoois a collection,getNestedFieldPath()now returns"foo.bar"instead of just"foo"(matching the behavior iffoois an object)As a result, filtering on deeply-nested paths (with 3 or more levels) now produces the following query:
{ "nested": { - "path": "foo", + "path": "foo.bar", "query": { "term": {"foo.bar.baz": "qux"} } } } }