docs: Explain how to disable the automatic integration with LexikJWTAuthenticationBundle #5719
Conversation
…uthenticationBundle With api-platform#5609 the integration of API Platform with LexikJWTAuthenticationBundle is automatically enabled. However, if we are not using the default configuration of LexikJWTAuthenticationBundle the documented operation is wrong (wrong path, wrong response in my case) and creates a duplicate. Since the behaviour of API Platform changed in a patch version maybe it's a good idea to explain directly in the changelog how to go back to the previous behaviour.
|
That behavior was incorrect and a "bug" that was fixed. In my case, it worked fine before (enabled automatically) after the upgrade I found it doesn't work anymore. Maybe push your docs suggestion on how to disable it to https://github.com/api-platform/docs/blob/3.1/core/jwt.md or https://github.com/lexik/LexikJWTAuthenticationBundle/blob/2.x/Resources/doc/index.rst#configuration? Thanks! |
|
we shouldn't prepend if you configured it manually, imo https://github.com/api-platform/core/pull/5609/files needs a patch no? |
|
Merging this for now, don't hesitate to provide a patch if there's something better to be done. Thanks! |
|
Detecting if a user has previously manually documented the login endpoint would be quite difficult, so I think it's good as-is. Enabling the API Platform integration when it's not needed just adds some "noise" in the swagger documentation but doesn't break existing apps, so it should be good. |
…uthenticationBundle (api-platform#5719) With api-platform#5609 the integration of API Platform with LexikJWTAuthenticationBundle is automatically enabled. However, if we are not using the default configuration of LexikJWTAuthenticationBundle the documented operation is wrong (wrong path, wrong response in my case) and creates a duplicate. Since the behaviour of API Platform changed in a patch version maybe it's a good idea to explain directly in the changelog how to go back to the previous behaviour.
3 participants
With #5609 the integration of API Platform with LexikJWTAuthenticationBundle is automatically enabled. However, if we are not using the default configuration of LexikJWTAuthenticationBundle the documented operation is wrong (wrong path, wrong response in my case) and creates a duplicate. Since the behaviour of API Platform changed in a patch version maybe it's a good idea to explain directly in the changelog how to go back to the previous behaviour.